Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382402 )
Change subject: Force query editor and hints left-to-right
......................................................................
Force query editor and hints left-to-right
SPARQL always reads left-to-right, so those elements should have ltr
direction even in rtl languages.
The CodeMirror-hints element is dynamically added and removed by
CodeMirror, so we set its direction with CSS.
Bug: T171564
Change-Id: If90a2b05e850c85a75d1ce22ca2aa54270133b1a
---
M index.html
M style.css
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/02/382402/1
diff --git a/index.html b/index.html
index 16b436d..946a003 100644
--- a/index.html
+++ b/index.html
@@ -161,7 +161,7 @@
</div>
</div>
<div
class="splitter"></div>
- <div
class="query-editor-container">
+ <div
class="query-editor-container" dir="ltr">
<textarea
class="queryEditor" name="query"
data-i18n="[placeholder]wdqs-app-editor-placeholder" placeholder="(Input a
SPARQL query or choose a query example)"></textarea>
</div>
</div>
diff --git a/style.css b/style.css
index 691431e..2dd0192 100644
--- a/style.css
+++ b/style.css
@@ -81,6 +81,10 @@
min-height: 320px;
}
+.CodeMirror-hints {
+ direction: ltr;
+}
+
.CodeMirror-hint {
max-width: 19em;
}
--
To view, visit https://gerrit.wikimedia.org/r/382402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If90a2b05e850c85a75d1ce22ca2aa54270133b1a
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
