jenkins-bot has submitted this change and it was merged.
Change subject: Introduce method ve.ce.Document.getRelativeOffset.
......................................................................
Introduce method ve.ce.Document.getRelativeOffset.
Change-Id: If2b8675b4604fc5ec1430497f2d55b2f3584a453
---
M modules/ve/ce/ve.ce.Document.js
1 file changed, 19 insertions(+), 1 deletion(-)
Approvals:
Christian: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/ve.ce.Document.js b/modules/ve/ce/ve.ce.Document.js
index ed918e9..79fd18a 100644
--- a/modules/ve/ce/ve.ce.Document.js
+++ b/modules/ve/ce/ve.ce.Document.js
@@ -99,7 +99,7 @@
config = direction > 0 ? config.right : config.left;
if ( !data[i] || data[i].type !== undefined ) {
- return -1;
+ return this.model.getRelativeContentOffset( offset, direction );
} else {
prevChar = typeof data[i] === 'string' ? data[i] : data[i][0];
if ( !pattern.test( prevChar ) ) {
@@ -134,4 +134,22 @@
} while ( data[i += inc] );
return i + ( inc > 0 ? 0 : 1 );
}
+};
+
+/**
+ * Get the relative word or character boundary.
+ *
+ * @method
+ * @param {number} offset Offset to start from
+ * @param {number} [direction] Direction to prefer matching offset in, -1 for
left and 1 for right
+ * @param {string} [unit] Unit [word|character]
+ * @returns {number} Relative offset
+ */
+ve.ce.Document.prototype.getRelativeOffset = function ( offset, direction,
unit ) {
+ if ( unit === 'word' ) { // word
+ return this.getSiblingWordBoundary( offset, direction );
+ } else { // character
+ // TODO: add support for slugs
+ return this.model.getRelativeContentOffset( offset, direction );
+ }
};
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/55297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2b8675b4604fc5ec1430497f2d55b2f3584a453
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Christian <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
