jenkins-bot has submitted this change and it was merged.
Change subject: Introduce helper functions.
......................................................................
Introduce helper functions.
* ve.ce.isLeftOrRightArrowKey
* ve.ce.isUpOrDownArrowKey
* ve.ce.isArrowKey
Change-Id: Id9fd7975e98085d01e545d1d0fc6086a06648031
---
M modules/ve/ce/ve.ce.js
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
Christian: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/ve.ce.js b/modules/ve/ce/ve.ce.js
index f3dd582..ab6644c 100644
--- a/modules/ve/ce/ve.ce.js
+++ b/modules/ve/ce/ve.ce.js
@@ -211,7 +211,7 @@
if ( addOuterLength === true ) {
return nodeModel.getOffset() +
nodeModel.getOuterLength();
} else {
- return nodeModel.getOffset();
+ return nodeModel.getOffset() +
(nodeModel.isWrapped() ? 1 : 0);
}
} else {
node = $domNode.contents().last()[0];
@@ -247,3 +247,15 @@
throw new Error( 'Incorrect slug location' );
}
};
+
+ve.ce.isLeftOrRightArrowKey = function ( keyCode ) {
+ return keyCode === ve.Keys.DOM_VK_LEFT || keyCode ===
ve.Keys.DOM_VK_RIGHT;
+};
+
+ve.ce.isUpOrDownArrowKey = function ( keyCode ) {
+ return keyCode === ve.Keys.DOM_VK_UP || keyCode === ve.Keys.DOM_VK_DOWN;
+};
+
+ve.ce.isArrowKey = function ( keyCode ) {
+ return ve.ce.isLeftOrRightArrowKey( keyCode ) ||
ve.ce.isUpOrDownArrowKey( keyCode );
+};
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/55298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9fd7975e98085d01e545d1d0fc6086a06648031
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Christian <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
