Fdans has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/382656 )

Change subject: Add link on each metric to its definition in meta-wiki
......................................................................

Add link on each metric to its definition in meta-wiki

Adds a new property in each metric's configuration that contains
the URL of its definition. It also adds a link to it in the detail page.

Bug: T176241
Change-Id: I7cb14ec7734d05b8890aebd1cf35c42dba6d20d8
---
M src/components/detail/GraphPanel.vue
M src/config.js
2 files changed, 16 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/wikistats2 
refs/changes/56/382656/1

diff --git a/src/components/detail/GraphPanel.vue 
b/src/components/detail/GraphPanel.vue
index dd14715..e84feec 100644
--- a/src/components/detail/GraphPanel.vue
+++ b/src/components/detail/GraphPanel.vue
@@ -3,7 +3,9 @@
     <div class="ui clearing basic segment">
         <div v-if="wiki">
             <h2 class="ui left floated header">
-                {{metricData.fullName || 'No data yet... '}}
+                <a class='metric link' :href="metricData.info_url" 
target="_blank">
+                    {{metricData.fullName || 'No data yet... '}}
+                </a>
                 <span class="subdued granularity">{{granularity}}</span>
             </h2>
 
@@ -45,7 +47,7 @@
                 </h5>
             </div>
             <div class="ui center aligned subdued basic segment">
-                <p>{{metricData.description}}</p>
+                <p>{{metricData.description}}. <a class='metric link' 
:href="metricData.info_url" target="_blank">More info about this metric.</a></p>
 
             </div>
             <div class="ui right floated icon button" 
@click="toggleFullscreen">
@@ -183,4 +185,13 @@
     text-transform: capitalize;
     font-style: italic;
 }
+
+.metric.link{
+    color: #000;
+    text-decoration: none;
+    border-bottom: 1px dashed black;
+}
+.metric.link:hover {
+    color: #6289D8;
+}
 </style>
diff --git a/src/config.js b/src/config.js
index 665046e..b372a7f 100644
--- a/src/config.js
+++ b/src/config.js
@@ -109,6 +109,7 @@
     'total-pageviews': {
         fullName: 'Total Page Views',
         description: 'A page view is a request for the content of a web page. 
Page views on Wikimedia projects is our most important content consumption 
metric.',
+        info_url: 'https://meta.wikimedia.org/wiki/Research:Page_view',
         defaults: {
             unique: {
                 project: ['all-projects'],
@@ -138,6 +139,8 @@
     },
     'unique-devices': {
         fullName: 'Unique Devices',
+        description: 'How many distinct devices we have visiting a project in 
a given time period.',
+        info_url: 'https://meta.wikimedia.org/wiki/Research:Unique_Devices',
         type: 'lines',
         defaults: {
             unique: {

-- 
To view, visit https://gerrit.wikimedia.org/r/382656
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cb14ec7734d05b8890aebd1cf35c42dba6d20d8
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikistats2
Gerrit-Branch: master
Gerrit-Owner: Fdans <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to