Giuseppe Lavagetto has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/382684 )

Change subject: role::cache::base: convert to profile [2]
......................................................................

role::cache::base: convert to profile [2]

Remove some unnneded includes

Change-Id: Idc8ba3f51ed440de0849f41624be414eba280654
---
M modules/profile/manifests/cache/base.pp
1 file changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/84/382684/1

diff --git a/modules/profile/manifests/cache/base.pp 
b/modules/profile/manifests/cache/base.pp
index 36d0ee4..873487f 100644
--- a/modules/profile/manifests/cache/base.pp
+++ b/modules/profile/manifests/cache/base.pp
@@ -17,15 +17,13 @@
     # Needed profiles
     require ::profile::conftool::client
     require ::profile::cache::kafka::webrequest
-    include ::standard
+    require ::standard
 
-    # Other includes - to fix
-    include ::nrpe
-    include lvs::configuration
-    include network::constants
-    include conftool::scripts
+    # TODO: this is properly a class in the prometheus module
     include ::role::prometheus::varnish_exporter
 
+    class { 'conftool::scripts':
+    }
     # Only production needs system perf tweaks
     if $::realm == 'production' {
         include role::cache::perf

-- 
To view, visit https://gerrit.wikimedia.org/r/382684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc8ba3f51ed440de0849f41624be414eba280654
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to