Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382687 )
Change subject: Use upstream OOUI icon for list images
......................................................................
Use upstream OOUI icon for list images
No need to keep a downstream copy after this.
Also minor style tweaks to match the other MW title widgets on the page:
* Remove border-radius
* Use background-size: cover for thumbnails
Change-Id: Id051ee4f9290004f1dda2ddc3d6dfa7a6d66e081
---
M modules/dashboard/ext.cx.suggestionlist.js
D modules/dashboard/images/page_lightgray.png
D modules/dashboard/images/page_lightgray.svg
M modules/dashboard/styles/ext.cx.lists.common.less
4 files changed, 8 insertions(+), 7 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/87/382687/1
diff --git a/modules/dashboard/ext.cx.suggestionlist.js
b/modules/dashboard/ext.cx.suggestionlist.js
index 475db6b..0abcdae 100644
--- a/modules/dashboard/ext.cx.suggestionlist.js
+++ b/modules/dashboard/ext.cx.suggestionlist.js
@@ -361,6 +361,8 @@
item.$image.css( {
'background-image': 'url(' +
page.thumbnail.source + ')'
} );
+ } else {
+ item.$image.addClass(
'oo-ui-icon-page-existing' );
}
if ( page.terms ) {
item.$desc.text( page.terms.description
).show();
diff --git a/modules/dashboard/images/page_lightgray.png
b/modules/dashboard/images/page_lightgray.png
deleted file mode 100644
index 43d5b58..0000000
--- a/modules/dashboard/images/page_lightgray.png
+++ /dev/null
Binary files differ
diff --git a/modules/dashboard/images/page_lightgray.svg
b/modules/dashboard/images/page_lightgray.svg
deleted file mode 100644
index c246ab7..0000000
--- a/modules/dashboard/images/page_lightgray.svg
+++ /dev/null
@@ -1,4 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 612 792">
- <path d="M321.385 365.23h123.077V211.386H321.385V365.23zm-153.847
61.54h276.924V396H167.538v30.77zm0 61.538h276.924v-30.77H167.538v30.77zm0
61.538h276.924v-30.77H167.538v30.77zm123.077-276.923H167.538v30.77h123.077v-30.77zm0
61.54H167.538v30.768h123.077v-30.768zm0-123.078H167.538v30.77h123.077v-30.77zM106
149.845h400v492.31H198.308c-52.308 0-92.308-40-92.308-92.31v-400z" id="path5"
fill="#c8ccd1"/>
-</svg>
diff --git a/modules/dashboard/styles/ext.cx.lists.common.less
b/modules/dashboard/styles/ext.cx.lists.common.less
index 08bd854..ad9a870 100644
--- a/modules/dashboard/styles/ext.cx.lists.common.less
+++ b/modules/dashboard/styles/ext.cx.lists.common.less
@@ -229,12 +229,15 @@
.cx-slitem__image {
.mw-ui-one-sixth;
- .background-image-svg('../../dashboard/images/page_lightgray.svg',
'../../dashboard/images/page_lightgray.png');
background-position: center center;
background-repeat: no-repeat;
- background-color: @gray-lighter;
+ background-size: cover;
width: 84px;
min-height: 84px;
- border-radius: @borderRadius;
padding: 0;
+ &.oo-ui-icon-page-existing {
+ background-size: 80%;
+ background-color: @gray;
+ opacity: 0.2;
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/382687
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id051ee4f9290004f1dda2ddc3d6dfa7a6d66e081
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
