jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/382849 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I802e07fb820bb49533f0bddde6e2ecf955752070
---
M DynamicSidebar.body.php
M phpcs.xml
2 files changed, 2 insertions(+), 6 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/DynamicSidebar.body.php b/DynamicSidebar.body.php
index 6a03481..bb5cc1b 100644
--- a/DynamicSidebar.body.php
+++ b/DynamicSidebar.body.php
@@ -5,7 +5,7 @@
* via callbacks.
*
* @param Skin $skin
- * @param array $sidebar
+ * @param array &$sidebar
* @return bool
*/
public static function modifySidebar( $skin, &$sidebar ) {
diff --git a/phpcs.xml b/phpcs.xml
index 75246d0..90e8108 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,13 +2,9 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
- <exclude-pattern>node_modules</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/382849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I802e07fb820bb49533f0bddde6e2ecf955752070
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DynamicSidebar
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
