Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/382951 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: Ia336b6bfe6f8c680590ba19e6ff7cee984707bd9
---
M SiteMatrixApi.php
M SiteMatrix_body.php
M phpcs.xml
3 files changed, 7 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SiteMatrix
refs/changes/51/382951/1
diff --git a/SiteMatrixApi.php b/SiteMatrixApi.php
index 2debcdd..2b52715 100644
--- a/SiteMatrixApi.php
+++ b/SiteMatrixApi.php
@@ -229,6 +229,7 @@
/**
* @see ApiBase::getExamplesMessages()
+ * @return array
*/
protected function getExamplesMessages() {
return [ 'action=sitematrix' => 'apihelp-sitematrix-example-1',
];
diff --git a/SiteMatrix_body.php b/SiteMatrix_body.php
index 1c85c44..1e78f61 100644
--- a/SiteMatrix_body.php
+++ b/SiteMatrix_body.php
@@ -357,7 +357,7 @@
* Handler method for the APISiteInfoGeneralInfo hook
*
* @param ApiQuerySiteinfo $module
- * @param array $results
+ * @param array &$results
* @return bool
*/
public static function APIQuerySiteInfoGeneralInfo( $module, &$results
) {
@@ -391,10 +391,10 @@
}
/**
- * @param Parser $parser
- * @param array $cache
- * @param string $magicWordId
- * @param string $ret
+ * @param Parser &$parser
+ * @param array &$cache
+ * @param string &$magicWordId
+ * @param string &$ret
* @param PPFrame $frame
* @return bool true
*/
@@ -412,7 +412,7 @@
}
/**
- * @param array $customVariableIds
+ * @param array &$customVariableIds
* @return bool true
*/
public static function onMagicWordwgVariableIDs( &$customVariableIds ) {
diff --git a/phpcs.xml b/phpcs.xml
index fa676a8..38d53b7 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,9 +2,6 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
@@ -13,5 +10,4 @@
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
<arg name="encoding" value="UTF-8" />
- <exclude-pattern>vendor</exclude-pattern>
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/382951
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia336b6bfe6f8c680590ba19e6ff7cee984707bd9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SiteMatrix
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
