jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/382879 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I875992087cd7a364d3ba2df3e98d370eb13f9271
---
M Insider.class.php
M phpcs.xml
2 files changed, 12 insertions(+), 8 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Insider.class.php b/Insider.class.php
index 99e699c..be42f35 100644
--- a/Insider.class.php
+++ b/Insider.class.php
@@ -21,7 +21,7 @@
class Insider {
/**
- * @param Parser $parser
+ * @param Parser &$parser
* @return bool
*/
public static function onParserFirstCallInit( Parser &$parser ) {
@@ -29,6 +29,10 @@
return true;
}
+ /**
+ * @param Parser $parser
+ * @return string
+ */
public static function onFuncInsider( Parser $parser ) {
$args = func_get_args();
array_shift( $args );
@@ -45,6 +49,11 @@
return '';
}
+ /**
+ * @param OutputPage &$out
+ * @param ParserOutput $parserOutput
+ * @return true
+ */
public static function onOutputPageParserOutput( OutputPage &$out,
ParserOutput $parserOutput ) {
$related = $parserOutput->getExtensionData( 'Insider' );
@@ -86,7 +95,7 @@
* Write out HTML-code.
*
* @param Skin $skin
- * @param array $bar
+ * @param array &$bar
* @return bool
*/
public static function onSidebarBeforeOutput( $skin, &$bar ) {
diff --git a/phpcs.xml b/phpcs.xml
index 2b6c00a..90e8108 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,14 +2,9 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
- <exclude-pattern>node_modules</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/382879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I875992087cd7a364d3ba2df3e98d370eb13f9271
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Insider
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
