VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383033 )

Change subject: Align colors to WikimediaUI palette ones
......................................................................

Align colors to WikimediaUI palette ones

Also cleaning up code a bit, removing unneeded LESS mixins and
using central ones via mediawiki.mixins where applicable.

Bug: T177712
Change-Id: Ia4cdeebde3803f1e72054014a43722631cf551fe
---
M resources/ext.gettingstarted.return.less
M resources/ext.gettingstarted.taskToolbar.less
M resources/lightbulb/lightbulb.common.less
M resources/lightbulb/lightbulb.flyout.less
M resources/lightbulb/lightbulb.postEdit.less
5 files changed, 17 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted 
refs/changes/33/383033/1

diff --git a/resources/ext.gettingstarted.return.less 
b/resources/ext.gettingstarted.return.less
index 2cb90bf..ee5d4c3 100644
--- a/resources/ext.gettingstarted.return.less
+++ b/resources/ext.gettingstarted.return.less
@@ -54,10 +54,10 @@
    one element
 */
 .mw-gettingstarted-cta {
-       border: 1px solid #999;
+       background-color: #fff;
+       border: 1px solid #a2a9b1;
        border-radius: @borderRadius;
        margin: auto;
-       background-color: #fff;
        padding: 20px 30px;
        overflow: auto;
        /* One z-index above overlay above */
@@ -76,16 +76,12 @@
 
                &.mw-gettingstarted-cta-secondary {
                        background-color: #f8f9fa;
-                       border: 1px solid #d3d3d3;
-                       color: #444;
+                       border: 1px solid #a2a9b1;
+                       color: #222;
 
                        &:hover {
-                               /*
-                                 TODO (mattflaschen, 2013-10-03): This is 
inconsistent with
-                                 normal mw.ui secondary buttons.  We should 
make them match.
-                               */
                                background-color: #fff;
-                               border-color: #ccc;
+                               color: #444;
                        }
                }
        }
diff --git a/resources/ext.gettingstarted.taskToolbar.less 
b/resources/ext.gettingstarted.taskToolbar.less
index 9290b17..365167a 100644
--- a/resources/ext.gettingstarted.taskToolbar.less
+++ b/resources/ext.gettingstarted.taskToolbar.less
@@ -1,11 +1,5 @@
 @import 'mediawiki.mixins';
 
-.box-shadow( ... ) {
-       -moz-box-shadow: @arguments;
-       -webkit-box-shadow: @arguments;
-       box-shadow: @arguments;
-}
-
 #mw-gettingstarted-toolbar.mw-gettingstarted-toolbar-expanded {
        .mw-gettingstarted-toolbar-center-message {
                display: block;
@@ -18,20 +12,15 @@
 
 /* css for entire top toolbar */
 #mw-gettingstarted-toolbar {
-       -webkit-box-sizing: border-box;
-       -moz-box-sizing: border-box;
-       box-sizing: border-box;
+       .box-sizing( border-box );
        font-family: 'Helvetica Neue', 'Helvetica', 'Arial', sans-serif;
        position: fixed;
        overflow: hidden;
        z-index: 100000006; /* I'm looking at you, Guiders */
        top: 0;
        width: 100%;
-
        .vertical-gradient( #7d7e7d, #333 );
-
        .box-shadow( inset 0px 1px #999, 0px 3px 3px #bbb );
-
        padding: 12px;
        font-size: 0.8em;
        color: #fff;
@@ -68,8 +57,8 @@
 
 /* X button in top toolbar */
 #mw-gettingstarted-toolbar a.mw-gettingstarted-toolbar-dismiss {
+       color: #72777d;
        font-size: 1.5em;
-       color: #aaa;
        margin-left: 15px;
 
        &:hover {
diff --git a/resources/lightbulb/lightbulb.common.less 
b/resources/lightbulb/lightbulb.common.less
index 7b9ec44..784b724 100644
--- a/resources/lightbulb/lightbulb.common.less
+++ b/resources/lightbulb/lightbulb.common.less
@@ -20,7 +20,6 @@
 .mw-gettingstarted-lightbulb-notification,
 .mw-gettingstarted-lightbulb-flyout {
        color: @colorGray5;
-
        white-space: nowrap;
 
        h1 {
@@ -63,9 +62,9 @@
 
                        &.mw-gettingstarted-lightbulb-suggestion-image-no-image 
{
                                background: no-repeat center;
+                               background-color: @colorGray14;
                                .background-image-svg( 
'../images/lightbulb/page.svg', '../images/lightbulb/page.png' );
                                background-size: 30px;
-                               background-color: @colorGray14;
                        }
                }
 
diff --git a/resources/lightbulb/lightbulb.flyout.less 
b/resources/lightbulb/lightbulb.flyout.less
index d6385ed..4d1221c 100644
--- a/resources/lightbulb/lightbulb.flyout.less
+++ b/resources/lightbulb/lightbulb.flyout.less
@@ -6,16 +6,13 @@
 .mw-gettingstarted-lightbulb-flyout {
        position: absolute;
        width: @flyoutWidth;
-
        font-size: 0.875em;
-
-       box-sizing: border-box;
+       .box-sizing( border-box );
 
        .mw-gettingstarted-lightbulb-flyout-heading {
                margin-bottom: 0;
                font-size: 1.5em;
        }
-
 }
 
 .mw-gettingstarted-lightbulb-flyout-text {
@@ -37,11 +34,11 @@
 .mw-gettingstarted-lightbulb-flyout-pagination-button-icon.mw-ui-button:active,
 
.mw-gettingstarted-lightbulb-flyout-pagination-button-icon.mw-ui-button[disabled]:hover
 {
        background-color: #fff;
+       background-position: center center;
+       background-repeat: no-repeat;
+       background-size: 14px 14px;
        width: 60px;
        height: 40px;
-       background-repeat: no-repeat;
-       background-position: center center;
-       background-size: 14px 14px;
        padding: 12px 22px;
 }
 
diff --git a/resources/lightbulb/lightbulb.postEdit.less 
b/resources/lightbulb/lightbulb.postEdit.less
index 7edcba7..cc317cf 100644
--- a/resources/lightbulb/lightbulb.postEdit.less
+++ b/resources/lightbulb/lightbulb.postEdit.less
@@ -13,17 +13,16 @@
        position: fixed;
        top: 10px;
        left: 50%;
-       margin-left: -@notificationWidth / 2;
        width: @notificationWidth;
        background-color: #fff;
-       color: #555;
+       color: #54595d;
+       margin-left: -@notificationWidth / 2;
+       border: 1px solid #c8ccd1;
+       border-radius: @borderRadius;
        font-size: 0.875em;
-
+       .box-shadow( 0 0 4px rgba( 0, 0, 0, 0.2 ) );
        // Be consistent with the default post-edit notification.
        z-index: 1000;
-
-       border: 1px solid #ccc;
-       .box-shadow( 0 0 4px rgba( 0, 0, 0, 0.2 ) );
 
        .mw-gettingstarted-lightbulb-notification-header {
                position: relative;

-- 
To view, visit https://gerrit.wikimedia.org/r/383033
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4cdeebde3803f1e72054014a43722631cf551fe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to