[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: CXSegmenter: Rewrite as ES6 class

[Santhosh (Code Review)]

Santhosh has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383108 )

Change subject: CXSegmenter: Rewrite as ES6 class
......................................................................

CXSegmenter: Rewrite as ES6 class

Change-Id: I3fdabadcba038f8095af6c65120f0598fec7a97f
---
M lib/segmentation/CXSegmenter.js
1 file changed, 40 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/cxserver 
refs/changes/08/383108/1

diff --git a/lib/segmentation/CXSegmenter.js b/lib/segmentation/CXSegmenter.js
index dbe952e..a1f793c 100644
--- a/lib/segmentation/CXSegmenter.js
+++ b/lib/segmentation/CXSegmenter.js
@@ -3,41 +3,48 @@
 var LinearDoc = require( '../lineardoc' ),
        segmenters = require( __dirname + '/languages' ).Segmenters;
 
-function CXSegmenter( content, language ) {
-       this.parser = new LinearDoc.Parser( new LinearDoc.MwContextualizer() );
-       this.parser.init();
-       this.getBoundaries = this.getSegmenter( language );
-       this.content = content;
-       this.originalDoc = null;
-       this.segmentedDoc = null;
-}
-
-CXSegmenter.prototype.segment = function () {
-       this.parser.write( this.content );
-       this.originalDoc = this.parser.builder.doc;
-       this.segmentedDoc = this.originalDoc.segment( this.getBoundaries );
-};
-
-/**
- * Get the segmenter for the given language.
- *
- * @param {string} language Language code
- * @return {Function} The segmenter function
- */
-CXSegmenter.prototype.getSegmenter = function ( language ) {
-       var segmenter;
-       if ( !segmenters[ language ] ) {
-               // fallback to default segmenter
-               segmenter = segmenters.default;
-       } else {
-               segmenter = segmenters[ language ];
+class CXSegmenter {
+       constructor( content, language ) {
+               this.parser = new LinearDoc.Parser( new 
LinearDoc.MwContextualizer() );
+               this.parser.init();
+               this.getBoundaries = this.getSegmenter( language );
+               this.content = content;
+               this.originalDoc = null;
+               this.segmentedDoc = null;
        }
 
-       return segmenter.getBoundaries;
-};
+       segment() {
+               this.parser.write( this.content );
+               this.originalDoc = this.parser.builder.doc;
+               this.segmentedDoc = this.originalDoc.segment( 
this.getBoundaries );
+       }
 
-CXSegmenter.prototype.getSegmentedContent = function () {
-       return this.segmentedDoc.getHtml();
-};
+       /**
+        * Get the segmenter for the given language.
+        *
+        * @param {string} language Language code
+        * @return {Function} The segmenter function
+        */
+       getSegmenter( language ) {
+               var segmenter;
+               if ( !segmenters[ language ] ) {
+                       // fallback to default segmenter
+                       segmenter = segmenters.default;
+               } else {
+                       segmenter = segmenters[ language ];
+               }
+
+               return segmenter.getBoundaries;
+       }
+
+       getSegmentedContent() {
+               return this.segmentedDoc.getHtml();
+       }
+
+       getSegmentedDoc() {
+               return this.segmentedDoc;
+       }
+
+}
 
 module.exports = CXSegmenter;

-- 
To view, visit https://gerrit.wikimedia.org/r/383108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fdabadcba038f8095af6c65120f0598fec7a97f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits