Mdale has submitted this change and it was merged.
Change subject: Dont show sourceSwitch for small videos
......................................................................
Dont show sourceSwitch for small videos
videos smaller than the smallest derivate dont need
sourceSwitch, this leavees space to show the seekbar.
Change-Id: I9dccffbfb26afd841a6c6b73a0fe0562fdc9bcb9
---
M MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Mdale: Verified; Looks good to me, approved
diff --git
a/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
b/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
index c2ec2c9..990bde6 100644
--- a/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
+++ b/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
@@ -245,6 +245,10 @@
if( componentId == 'fullscreen' &&
this.embedPlayer.isAudio() ){
continue;
}
+ // Skip sourceSwitch if width < smalles derivative
+ if ( componentId == 'sourceSwitch' &&
this.availableWidth < 320) {
+ continue;
+ }
addComponent( componentId );
}
if( this.availableWidth > 30 ){
--
To view, visit https://gerrit.wikimedia.org/r/54644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9dccffbfb26afd841a6c6b73a0fe0562fdc9bcb9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J <[email protected]>
Gerrit-Reviewer: Mdale <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
