jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/382680 )
Change subject: RTL support for form elements
......................................................................
RTL support for form elements
Use shared DOM container for all AdvancedSearch elements. Indicate
AdvancedSearch is developed LTR, allow flip.
Issue: T175826
Change-Id: I135698a3cf83d7449fb31b03604a1f26f4b60884
---
M modules/ext.advancedSearch.css
M modules/ext.advancedSearch.init.js
2 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
Gabriel Birke: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.advancedSearch.css b/modules/ext.advancedSearch.css
index a2f025a..66e3a3f 100644
--- a/modules/ext.advancedSearch.css
+++ b/modules/ext.advancedSearch.css
@@ -1,3 +1,9 @@
+.mw-advancedSearch-container textarea,
+.mw-advancedSearch-container input {
+ /* This will flip with CSSJanus */
+ direction: ltr;
+}
+
.mw-advancedSearch-searchPreview-label {
font-weight: bold;
margin-right: 0.3125em;
diff --git a/modules/ext.advancedSearch.init.js
b/modules/ext.advancedSearch.init.js
index 48a4291..63f83fe 100644
--- a/modules/ext.advancedSearch.init.js
+++ b/modules/ext.advancedSearch.init.js
@@ -337,8 +337,11 @@
}
var $search = $( 'form#search, form#powersearch' ),
+ $advancedSearch = $( '<div>' ).addClass(
'mw-advancedSearch-container' ),
$searchField = $search.find( 'input[name="search"]' ),
optionSets = {};
+
+ $search.append( $advancedSearch );
$searchField.val( mw.util.getParamValue(
'advancedSearchOption-original' ) );
@@ -418,7 +421,7 @@
searchPreview.showPreview();
}
} );
- $( '.mw-search-profile-tabs' ).before( pane.$element );
+ $advancedSearch.append( pane.$element );
$search.on( 'submit', function () {
var compiledQuery = $.trim( $searchField.val() + ' ' +
formatSearchOptions().join( ' ' ) ),
@@ -435,7 +438,7 @@
name: 'advancedSearch-current'
} );
- $search.append( currentSearch.$element );
+ $advancedSearch.append( currentSearch.$element );
var namespaceSelection = new
mw.libs.advancedSearch.ui.NamespaceFilters( state, {
namespaces: prepareNamespaces()
@@ -451,7 +454,7 @@
} ),
namespaceSelectionPreview = $( '<div
class="mw-advancedSearch-namespace-selection"></div>' );
- $( '.mw-search-profile-tabs' ).after( namespaceSelectionPreview );
+ $advancedSearch.append( namespaceSelectionPreview );
namespaceSelectionPreview
.after( namespaceSelection.$element )
.append( $( '<strong></strong>' ).text( mw.msg(
'advancedSearch-namespaces-search-in' ) ) )
--
To view, visit https://gerrit.wikimedia.org/r/382680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I135698a3cf83d7449fb31b03604a1f26f4b60884
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdvancedSearch
Gerrit-Branch: master
Gerrit-Owner: Pablo Grass (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Andrew-WMDE <[email protected]>
Gerrit-Reviewer: Gabriel Birke <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
