jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383046 )
Change subject: Extract new code into dedicated method ...................................................................... Extract new code into dedicated method Follow up to https://gerrit.wikimedia.org/r/#/c/382703/ Change-Id: I1f80af893db2a2376e0a9a6913806c018b80e2be --- M modules/ui/ext.advancedSearch.NamespaceFilters.js 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: jenkins-bot: Verified Kai Nissen (WMDE): Looks good to me, approved diff --git a/modules/ui/ext.advancedSearch.NamespaceFilters.js b/modules/ui/ext.advancedSearch.NamespaceFilters.js index 79b7282..c0a21f3 100644 --- a/modules/ui/ext.advancedSearch.NamespaceFilters.js +++ b/modules/ui/ext.advancedSearch.NamespaceFilters.js @@ -163,21 +163,25 @@ } ); }; + mw.libs.advancedSearch.ui.NamespaceFilters.prototype.disableSelectedNamespacesInMenu = function () { + var self = this; + + $.each( this.getMenu().getItems(), function ( index, menuItem ) { + menuItem.setDisabled( !!self.getItemFromData( menuItem.getData() ) ); + } ); + }; + /** * Respond to change event, where items were added, removed, or cleared. * * Overrides OO.ui.TagMultiselectWidget.prototype.onChangeTags default behaviour to add GUI effect */ mw.libs.advancedSearch.ui.NamespaceFilters.prototype.onChangeTags = function () { - var self = this, - tagItems = this.getItems(), - menuItems = this.getMenu().getItems(); - mw.libs.advancedSearch.ui.NamespaceFilters.parent.prototype.onChangeTags.call( this ); - $.each( menuItems, function ( index, menuItem ) { - menuItem.setDisabled( !!self.getItemFromData( menuItem.getData() ) ); - } ); + this.disableSelectedNamespacesInMenu(); + + var tagItems = this.getItems(); if ( tagItems.length > 0 ) { tagItems[ 0 ].setDisabled( tagItems.length === 1 ); -- To view, visit https://gerrit.wikimedia.org/r/383046 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f80af893db2a2376e0a9a6913806c018b80e2be Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AdvancedSearch Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: Andrew-WMDE <[email protected]> Gerrit-Reviewer: Kai Nissen (WMDE) <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> Gerrit-Reviewer: WMDE-Fisch <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
