Mdale has submitted this change and it was merged.
Change subject: (bug 45557) use inline fallback with link for audio
......................................................................
(bug 45557) use inline fallback with link for audio
instead of displaying a large fallback message that breaks the
layout, show fallback player with a direct link to the audio file
if the browser can not play the available formats.
Change-Id: Ie5f19388d83555b1183494d7c158313260c4387d
---
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Mdale: Verified; Looks good to me, approved
diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
index 1c74dc4..25500d1 100644
--- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
+++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
@@ -1331,11 +1331,6 @@
{
return ;
}
- // if an audio player we don't have room for error
message interface:
- if( this.isAudio() ){
- $( this ).parent().parent().replaceWith(
this.noPlayerFallbackHTML );
- return ;
- }
// Set the isLink player flag:
this.isLinkPlayer= true;
// Update the poster and html:
--
To view, visit https://gerrit.wikimedia.org/r/53528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5f19388d83555b1183494d7c158313260c4387d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J <[email protected]>
Gerrit-Reviewer: Mdale <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
