Ejegg has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382106 )
Change subject: Remove attempt to set sort_name & display_name. ...................................................................... Remove attempt to set sort_name & display_name. On testing I found that what we were setting was being ignored (otherwise the cleanups would not have flowed through). I have done an upstream PR to address length handling in core https://github.com/civicrm/civicrm-core/pull/11063 I don't think it's pressing for us to address long_name handling (ie. we can suck that PR in now or wait for the next update) but removing these 2 lines gets rid of the misleading impression that they have an effect Change-Id: I0be0a8883e19378019adf29f9b4cb76add4e812e --- M sites/all/modules/wmf_civicrm/wmf_civicrm.module 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: jenkins-bot: Verified Ejegg: Looks good to me, approved diff --git a/sites/all/modules/wmf_civicrm/wmf_civicrm.module b/sites/all/modules/wmf_civicrm/wmf_civicrm.module index 50eaab3..8dfffbf 100644 --- a/sites/all/modules/wmf_civicrm/wmf_civicrm.module +++ b/sites/all/modules/wmf_civicrm/wmf_civicrm.module @@ -1079,9 +1079,6 @@ $contact[$name] = substr(trim($msg[$name]), 0, 64); } } - // @todo this may not be needed as core may handle, but unsure how it handles over-long strings. - $contact['sort_name'] = substr(trim($msg['last_name'] . ', ' . $msg['first_name'], ' ,'), 0, 128); - $contact['display_name'] = substr($msg['first_name'] . ' ' . $msg['last_name'], 0, 128 ); } if ( strtolower( $msg['contact_type'] ) == "organization" ){ // @todo probably can remove handling for sort name and display name now. -- To view, visit https://gerrit.wikimedia.org/r/382106 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0be0a8883e19378019adf29f9b4cb76add4e812e Gerrit-PatchSet: 2 Gerrit-Project: wikimedia/fundraising/crm Gerrit-Branch: master Gerrit-Owner: Eileen <emcnaugh...@wikimedia.org> Gerrit-Reviewer: Ejegg <ej...@ejegg.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
