Dr0ptp4kt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/55444


Change subject: Reducing default memcaching of carrier preferences from 3600 
seconds (60 minutes) to 900 seconds (15 minutes). After this reduces the pain, 
we can consider refactoring to hit the local endpoint to obtain the options.. 
Currently, the carrier prefs are pull
......................................................................

Reducing default memcaching of carrier preferences from 3600
seconds (60 minutes) to 900 seconds (15 minutes). After this
reduces the pain, we can consider refactoring to hit the local
endpoint to obtain the options.. Currently, the carrier prefs are
pulled remotely via an HTTP GET off of en.wikipedia instead of
with a straight wfMessage hit.. The three cases where the prefs
are cached rely upon self::getMaxAge(). self::getMaxAge()
is not invoked elsewhere, meaning this is isolated.

Change-Id: Ie86dc96fdd9e7cca482780cb1228d1394f07a4e9
---
M ZeroRatedMobileAccess.body.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess 
refs/changes/44/55444/1

diff --git a/ZeroRatedMobileAccess.body.php b/ZeroRatedMobileAccess.body.php
index 99ceffa..7c575e8 100644
--- a/ZeroRatedMobileAccess.body.php
+++ b/ZeroRatedMobileAccess.body.php
@@ -877,7 +877,7 @@
                // add 10 seconds to cater for the time deviation between 
servers
                $expiry = self::todaysStart() + 24 * 3600 - wfTimestamp() + 10;
                wfProfileOut( __METHOD__ );
-               return min( $expiry, 3600 );
+               return min( $expiry, 900 );
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/55444
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie86dc96fdd9e7cca482780cb1228d1394f07a4e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroRatedMobileAccess
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to