Cicalese has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379833 )
Change subject: Fix rendering in search results
......................................................................
Fix rendering in search results
Wrap the string containing the title icon and link text
in an instance of HtmlArmor in order to prevent the html
from being escaped when it is rendered. Note that using
HtmlArmor increases the required MediaWiki version
to 1.28.
Change-Id: Ifd38a19d18c96339180ade7d56aad3ffd043ce6e
---
M TitleIcon.php
M extension.json
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Cicalese: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/TitleIcon.php b/TitleIcon.php
index 1365971..cc8b2f6 100644
--- a/TitleIcon.php
+++ b/TitleIcon.php
@@ -160,7 +160,7 @@
public function handleSearchTitle( &$text ) {
$iconhtml = $this->getIconHTML();
if ( strlen( $iconhtml ) > 0 ) {
- $text = $iconhtml . Linker::link( $this->title );
+ $text = new HtmlArmor($iconhtml . Linker::link(
$this->title ));
}
}
diff --git a/extension.json b/extension.json
index da5bb4b..8e62df6 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
{
"name": "Title Icon",
- "version": "3.0",
+ "version": "4.0",
"author": [
"[https://www.mediawiki.org/wiki/User:Cindy.cicalese Cindy
Cicalese]"
],
--
To view, visit https://gerrit.wikimedia.org/r/379833
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd38a19d18c96339180ade7d56aad3ffd043ce6e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TitleIcon
Gerrit-Branch: master
Gerrit-Owner: Matthew-a-thompson <[email protected]>
Gerrit-Reviewer: Cicalese <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
