Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383347 )
Change subject: Don't request render if renderer not configured
......................................................................
Don't request render if renderer not configured
If $mwCollectionMWServeURL is falsy, then don't try make an HTTP request
to the rendering backend. Instead, log a helpful message to the
"collection" log group.
Bug: T177795
Change-Id: Ia33e7f72b4d3cbbea6c8e939ea80ef05c179648f
---
M RenderingAPI.php
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection
refs/changes/47/383347/1
diff --git a/RenderingAPI.php b/RenderingAPI.php
index 397872d..2593416 100644
--- a/RenderingAPI.php
+++ b/RenderingAPI.php
@@ -301,14 +301,22 @@
// If $serveURL has a | in it, we need to use a proxy.
list( $proxy, $serveURL ) = array_pad( explode( '|', $serveURL,
2 ), -2, '' );
+ if ( !$serveURL ) {
+ wfDebugLog( 'collection', 'The mwlib/OCG render server
URL isn\'t configured.' );
+
+ return new CollectionAPIResult( false );
+ }
+
$response = Http::post(
$serveURL,
[ 'postData' => $params, 'proxy' => $proxy ],
__METHOD__
);
+
if ( $response === false ) {
wfDebugLog( 'collection', "Request to $serveURL
resulted in error" );
}
+
return new CollectionAPIResult( $response );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/383347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia33e7f72b4d3cbbea6c8e939ea80ef05c179648f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
