Elukey has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383351 )
Change subject: wmf_auto_reimage_host: fix check in mgmt interfaces
......................................................................
wmf_auto_reimage_host: fix check in mgmt interfaces
Change-Id: Ib57843148adb87a4ecd43abdcd11060017d52275
---
M modules/profile/files/cumin/wmf_auto_reimage_host.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Elukey: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/profile/files/cumin/wmf_auto_reimage_host.py
b/modules/profile/files/cumin/wmf_auto_reimage_host.py
index 3335bd7..4dabe03 100644
--- a/modules/profile/files/cumin/wmf_auto_reimage_host.py
+++ b/modules/profile/files/cumin/wmf_auto_reimage_host.py
@@ -62,8 +62,11 @@
raise argparse.ArgumentTypeError(
"Unable to resolve host '{name}'".format(name=name))
- if '.mgmt.' not in mgmts.values():
- raise argparse.ArgumentTypeError('The MGMT parameter must be in the
*.mgmt.* format')
+ for mgmt in mgmts.values():
+ if '.mgmt.' not in mgmt:
+ raise argparse.ArgumentTypeError(
+ 'The MGMT parameter {} does not follow the *.mgmt.*
format'.format(mgmt)
+ )
return args
--
To view, visit https://gerrit.wikimedia.org/r/383351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib57843148adb87a4ecd43abdcd11060017d52275
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <[email protected]>
Gerrit-Reviewer: Elukey <[email protected]>
Gerrit-Reviewer: Volans <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
