Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383405 )
Change subject: Fix: remove unsupported revision parameter from summary endpoint ...................................................................... Fix: remove unsupported revision parameter from summary endpoint The summary endpoint doesn't actually support revisions. Remove support in Marvin. Change-Id: If44c812def13ef863bdcd1a3aecf9a2a9d5514ac --- M src/common/data-clients/page-summary-data-client.ts 1 file changed, 2 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/05/383405/1 diff --git a/src/common/data-clients/page-summary-data-client.ts b/src/common/data-clients/page-summary-data-client.ts index c0b6d0d..072d264 100644 --- a/src/common/data-clients/page-summary-data-client.ts +++ b/src/common/data-clients/page-summary-data-client.ts @@ -8,18 +8,12 @@ // https://en.wikipedia.org/api/rest_v1/#!/Page_content/get_page_summary_title export interface Params { titlePath: PageTitlePath; - revision?: number; - timeID?: string; redirect?: PageRedirect; } -const url = ({ titlePath, revision, timeID, redirect }: Params) => { - const revisionPath = revision === undefined ? "" : `/${revision}`; - const timeIDPath = timeID === undefined ? "" : `/${timeID}`; +const url = ({ titlePath, redirect }: Params) => { const redirectParam = redirect === undefined ? "" : `&redirect=${redirect}`; - - // eslint-disable-next-line max-len - return `${RESTBase.BASE_URL}/page/summary/${titlePath}${revisionPath}${timeIDPath}${redirectParam}`; + return `${RESTBase.BASE_URL}/page/summary/${titlePath}${redirectParam}`; }; const HEADERS = { -- To view, visit https://gerrit.wikimedia.org/r/383405 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If44c812def13ef863bdcd1a3aecf9a2a9d5514ac Gerrit-PatchSet: 1 Gerrit-Project: marvin Gerrit-Branch: master Gerrit-Owner: Niedzielski <[email protected]> Gerrit-Reviewer: Sniedzielski <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
