jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383323 )

Change subject: Hide embed logo after rendering result
......................................................................


Hide embed logo after rendering result

If result view does not use 100% VH Wikidata logo should not be visible
after rendering result.

Change-Id: If6e351867f8d745cfa587bba8abdb9a9d84b1fa7
---
M embed.html
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Smalyshev: Looks good to me, approved
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/embed.html b/embed.html
index 840738d..3fc56e8 100644
--- a/embed.html
+++ b/embed.html
@@ -269,7 +269,9 @@
                                $( 'body' ).i18n();
                                $( 'html' ).attr( { lang: lang, dir: 
$.uls.data.getDir( lang ) } );
 
-                               resultView.draw( query );
+                               resultView.draw( query ).done( function() {
+                                       $( '.logo' ).hide();
+                               } );
                                renderEdit( query, function( q ){
                                        resultView.draw( q );
                                        window.location.hash = '#' + 
encodeURIComponent( q )

-- 
To view, visit https://gerrit.wikimedia.org/r/383323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6e351867f8d745cfa587bba8abdb9a9d84b1fa7
Gerrit-PatchSet: 3
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to