Eileen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383501 )
Change subject: CRM-21294 Fix js error on dedupe find screen.
......................................................................
CRM-21294 Fix js error on dedupe find screen.
This is an error on selecting & unselecting contacts on the merge screen.
A js error was causing selection issues.
Bug: T177873
Change-Id: Iaa24a54647b79c8700473e49e9371e51f5134e10
---
M templates/CRM/Contact/Page/DedupeFind.tpl
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm/civicrm
refs/changes/01/383501/1
diff --git a/templates/CRM/Contact/Page/DedupeFind.tpl
b/templates/CRM/Contact/Page/DedupeFind.tpl
index df90aa0..43002b1 100644
--- a/templates/CRM/Contact/Page/DedupeFind.tpl
+++ b/templates/CRM/Contact/Page/DedupeFind.tpl
@@ -189,7 +189,7 @@
}
// for action column at the last, set nowrap
$('td:last', row).attr('nowrap','nowrap');
- // for conflcts column
+ // for conflicts column
var col = CRM.$('table#dupePairs thead
th.crm-contact-conflicts').index();
$('td:eq(' + col + ')', row).attr('nowrap','nowrap');
}
@@ -334,8 +334,10 @@
else {
var id = [];
CRM.$(element).each(function() {
- var sth = CRM.$('input.crm-dedupe-select', this);
- id.push(CRM.$(sth).prop('name').substr(5));
+ var pnName = CRM.$('input.crm-dedupe-select', this).prop('name');
+ if (pnName !== undefined) {
+ id.push(pnName.substr(5));
+ }
});
var is_selected = CRM.$('.crm-dedupe-select-all').prop('checked') ? 1 :
0;
}
--
To view, visit https://gerrit.wikimedia.org/r/383501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa24a54647b79c8700473e49e9371e51f5134e10
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/civicrm
Gerrit-Branch: master
Gerrit-Owner: Eileen <emcnaugh...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
