Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383551 )
Change subject: Add tracking for fallout from fix for T177707
......................................................................
Add tracking for fallout from fix for T177707
Bug: T177707
Change-Id: I1c7766f795c15bef31e3824213c70f7b33113463
---
M client/includes/Changes/WikiPageUpdater.php
M client/tests/phpunit/includes/Changes/WikiPageUpdaterTest.php
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/51/383551/1
diff --git a/client/includes/Changes/WikiPageUpdater.php
b/client/includes/Changes/WikiPageUpdater.php
index 70b9659..a5c6eee 100644
--- a/client/includes/Changes/WikiPageUpdater.php
+++ b/client/includes/Changes/WikiPageUpdater.php
@@ -241,6 +241,9 @@
$this->incrementStats( 'InjectRCRecords.jobs', count( $jobs ) );
$this->incrementStats( 'InjectRCRecords.titles', $titleCount );
+
+ // tracking fallout of the hacky fix for T177707
+ $this->incrementStats( 'InjectRCRecords.discardedTitles',
count( $titles ) - $titleCount );
}
}
diff --git a/client/tests/phpunit/includes/Changes/WikiPageUpdaterTest.php
b/client/tests/phpunit/includes/Changes/WikiPageUpdaterTest.php
index 97b9df1..8614998 100644
--- a/client/tests/phpunit/includes/Changes/WikiPageUpdaterTest.php
+++ b/client/tests/phpunit/includes/Changes/WikiPageUpdaterTest.php
@@ -279,6 +279,7 @@
// FIXME: Because of the hot fix for T177707 we
expect only the first batch.
'InjectRCRecords.jobs' => 1,
'InjectRCRecords.titles' => 2,
+ 'InjectRCRecords.discardedTitles' => 1,
] )
);
$updater->setRecentChangesBatchSize( 2 );
--
To view, visit https://gerrit.wikimedia.org/r/383551
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c7766f795c15bef31e3824213c70f7b33113463
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
