jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/382476 )

Change subject: Add high-specificity copy of .wbqc-reports-button
......................................................................


Add high-specificity copy of .wbqc-reports-button

ooui-js has a higher-specificity selector for button elements that
removes the left margin. Since it includes a :first-child pseudo-class,
it only applies to constraint report buttons on statements where the
Wikibase-emitted snak doesn’t include any elements, only text nodes
(e. g. time, string, globecoordinate), and since the current logos
include some spacing as well (especially the “warning” logo), the
missing left margin wasn’t very noticeable in those cases. However, with
the new logos of T171586 the missing space becomes a lot more noticable.

Change-Id: I337636b01986652adb1eb20d5e2a003f5f460f2c
---
M modules/gadget.css
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/modules/gadget.css b/modules/gadget.css
index b52c354..3f7e1d5 100644
--- a/modules/gadget.css
+++ b/modules/gadget.css
@@ -1,6 +1,7 @@
 /* named colors refer to the Wikimedia Style Guide, 
https://wikimedia.github.io/WikimediaUI-Style-Guide/visual-style_colors.html */
 
-.wbqc-reports-button {
+.wbqc-reports-button,
+.oo-ui-buttonElement.oo-ui-iconElement.wbqc-reports-button {
        margin-left: 0.5em;
 }
 .wbqc-report,

-- 
To view, visit https://gerrit.wikimedia.org/r/382476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I337636b01986652adb1eb20d5e2a003f5f460f2c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to