Hello Daniel Kinzler, Tim Starling, Legoktm,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/383927
to review the following change.
Change subject: Update for deprecation of selectFields() methods
......................................................................
Update for deprecation of selectFields() methods
Various selectFields() methods were deprecated in MediaWiki core change
Idcfd1556, replaced with getQueryInfo() methods.
Change-Id: I488afaa991e3d26b638a4f588f70db455959eadf
Depends-On: Idcfd15568489d9f03a7ba4460e96610d33bc4089
---
M includes/Model/AbstractRevision.php
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/27/383927/1
diff --git a/includes/Model/AbstractRevision.php
b/includes/Model/AbstractRevision.php
index c08a81b..8a6f112 100644
--- a/includes/Model/AbstractRevision.php
+++ b/includes/Model/AbstractRevision.php
@@ -850,7 +850,15 @@
$options = [ 'USE INDEX' => 'rc_timestamp' ];
$dbr = wfGetDB( DB_REPLICA );
- $rows = $dbr->select( 'recentchanges',
RecentChange::selectFields(), $conditions, __METHOD__, $options );
+ $rcQuery = RecentChange::getQueryInfo();
+ $rows = $dbr->select(
+ $rcQuery['tables'],
+ $rcQuery['fields'],
+ $conditions,
+ __METHOD__,
+ $options,
+ $rcQuery['joins']
+ );
if ( $rows === false ) {
return null;
--
To view, visit https://gerrit.wikimedia.org/r/383927
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I488afaa991e3d26b638a4f588f70db455959eadf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Tim Starling <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
