Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384234 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I9561d6fc4c95a13513ba5619c309647996119816
---
M PetitionHooks.php
M SpecialPetition.php
M phpcs.xml
3 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Petition
refs/changes/34/384234/1
diff --git a/PetitionHooks.php b/PetitionHooks.php
index 5d998c7..624f4bb 100644
--- a/PetitionHooks.php
+++ b/PetitionHooks.php
@@ -4,6 +4,8 @@
/**
* Adds database table to updater
+ * @param DatabaseUpdater $updater
+ * @return true
*/
public static function getUpdates( DatabaseUpdater $updater ) {
$updater->addExtensionTable( 'petition_data', __DIR__ .
'/table.sql', true );
diff --git a/SpecialPetition.php b/SpecialPetition.php
index 2ca4e20..1ed12fd 100644
--- a/SpecialPetition.php
+++ b/SpecialPetition.php
@@ -65,7 +65,7 @@
/**
* Save into petition_data table
*
- * @param $formData
+ * @param array $formData
* @return true if success
* @throws ReadOnlyError
*/
diff --git a/phpcs.xml b/phpcs.xml
index 1f092a3..b15894e 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,15 +2,10 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
<arg name="encoding" value="UTF-8" />
- <exclude-pattern>vendor</exclude-pattern>
- <exclude-pattern>node_modules</exclude-pattern>
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/384234
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9561d6fc4c95a13513ba5619c309647996119816
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Petition
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
