Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384242 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I5272fbd2c87b023013eca5c90a36b6042d3f308d
---
M Timeline.body.php
M phpcs.xml
2 files changed, 6 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/timeline
refs/changes/42/384242/1
diff --git a/Timeline.body.php b/Timeline.body.php
index 3603279..b6c3926 100644
--- a/Timeline.body.php
+++ b/Timeline.body.php
@@ -4,7 +4,7 @@
class Timeline {
/**
- * @param $parser Parser
+ * @param Parser &$parser
* @return bool
*/
public static function onParserFirstCallInit( &$parser ) {
@@ -23,8 +23,8 @@
* will be reused if the hash match. You can invalidate the cache by
* setting the global variable $wgRenderHashAppend (default: '').
*
- * @param $timelinesrc string
- * @param $args array
+ * @param string $timelinesrc
+ * @param array $args
* @param Parser $parser
* @param PPFrame $frame
* @throws Exception
@@ -220,8 +220,8 @@
* the cache as a side effect though old files will be left in the file
* backend.
*
- * @param $timelinesrc string
- * @param $args array
+ * @param string $timelinesrc
+ * @param array $args
* @return string hash
*/
public static function hash( $timelinesrc, array $args ) {
@@ -237,7 +237,7 @@
/**
* Do a security check on the image map HTML
- * @param $html string
+ * @param string $html
* @return string HTML
*/
private static function fixMap( $html ) {
diff --git a/phpcs.xml b/phpcs.xml
index 9e92a16..b374cbf 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,13 +2,9 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>
<arg name="encoding" value="UTF-8"/>
- <exclude-pattern>vendor/</exclude-pattern>
- <exclude-pattern>node_modules/</exclude-pattern>
</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/384242
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5272fbd2c87b023013eca5c90a36b6042d3f308d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/timeline
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
