Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55569
Change subject: Return false after click event handlers
......................................................................
Return false after click event handlers
To prevent the events propage and cause unwanted results
Change-Id: Ife7f3f80cce343c0473a24bb0042cb835a1fc090
---
M resources/js/ext.translate.editor.js
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/69/55569/1
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index 1d8698f..276bc48 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -262,6 +262,7 @@
.attr( 'title', mw.msg(
'tux-editor-close-tooltip' ) )
.on( 'click', function () {
translateEditor.hide();
+ return false;
} );
$infoToggleIcon = $( '<span>' )
@@ -271,6 +272,7 @@
.attr( 'title', mw.msg(
'tux-editor-expand-tooltip' ) )
.on( 'click', function () {
translateEditor.infoToggle( $( this ) );
+ return false;
} );
$layoutActions = $( '<div>' )
@@ -469,6 +471,7 @@
.text( mw.msg(
'tux-editor-save-button-label' ) )
.on( 'click', function () {
translateEditor.save();
+ return false;
} );
// When the user opens an outdated translation,
the main button should be enabled
@@ -505,6 +508,7 @@
.on( 'click', function () {
translateEditor.skip();
translateEditor.next();
+ return false;
} );
$controlButtonBlock = $( '<div>' )
--
To view, visit https://gerrit.wikimedia.org/r/55569
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife7f3f80cce343c0473a24bb0042cb835a1fc090
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
