jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/384748 )

Change subject: ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons
......................................................................


ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons

OOjs UI's styles now include 'top: 0' for icons, which messes us up here.

Bug: T178415
Change-Id: Ia3234848f69fd67d0b3e35c817de1d9847d46143
(cherry picked from commit 99cdc08f53b00452d134579dec5a609b6ac5978e)
---
M modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css 
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css
index e2b8e36..ead4d1e 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css
@@ -10,6 +10,7 @@
        margin: 0.05em;
        height: 1.9em;
        position: absolute;
+       top: auto;
        opacity: 0.5;
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/384748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3234848f69fd67d0b3e35c817de1d9847d46143
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.31.0-wmf.4
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Bartosz DziewoƄski <matma....@gmail.com>
Gerrit-Reviewer: Thcipriani <tcipri...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to