Santhosh has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384932 )
Change subject: CX2: Give placeholder sections for blocklevel templates
......................................................................
CX2: Give placeholder sections for blocklevel templates
cxserver /translate api now gives adapted template for target
language.
Eventhough the adapted template's editing is not there yet and
we need to think how to render the block level templates in UI,
this will help development and testing of template adaptations
Change-Id: Iefde67adf9aac7b0162473d8f9e701533ea125b8
---
M modules/dm/mw.cx.dm.Translation.js
1 file changed, 3 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/32/384932/1
diff --git a/modules/dm/mw.cx.dm.Translation.js
b/modules/dm/mw.cx.dm.Translation.js
index dc9e585..1856841 100644
--- a/modules/dm/mw.cx.dm.Translation.js
+++ b/modules/dm/mw.cx.dm.Translation.js
@@ -100,10 +100,9 @@
sectionNode = domDoc.createElement( 'section' );
aboutGroup = node.getAttribute( 'about' );
- // For block level templates and their about-grouped
siblings, don't give them
- // a section ID as they can't be translated yet
- // TODO: handle more systematically
- if ( ( aboutGroup && aboutGroup === lastAboutGroup ) ||
( node.getAttribute( 'typeof' ) || '' ).match( /\bmw:Transclusion\b/ ) ) {
+ // For about-grouped siblings of block level templates
don't give them
+ // a section ID
+ if ( ( aboutGroup && aboutGroup === lastAboutGroup ) ) {
lastAboutGroup = aboutGroup;
} else {
sectionNode.setAttribute( 'id', sectionIdPrefix
+ nextSectionId );
--
To view, visit https://gerrit.wikimedia.org/r/384932
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefde67adf9aac7b0162473d8f9e701533ea125b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
