jenkins-bot has submitted this change and it was merged.
Change subject: QUnit: Re-enable config.requireExpects and add missing numbers.
......................................................................
QUnit: Re-enable config.requireExpects and add missing numbers.
Change-Id: I214b3d4da46f3f3bb0fcde313ac2d82439e40e3c
---
M tests/qunit/data/testrunner.js
M tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
M
tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
3 files changed, 10 insertions(+), 8 deletions(-)
Approvals:
Demon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/qunit/data/testrunner.js b/tests/qunit/data/testrunner.js
index 77db213..f707588 100644
--- a/tests/qunit/data/testrunner.js
+++ b/tests/qunit/data/testrunner.js
@@ -36,6 +36,8 @@
tooltip: 'Enable debug mode in ResourceLoader'
} );
+ QUnit.config.requireExpects = true;
+
/**
* Load TestSwarm agent
*/
@@ -52,7 +54,7 @@
/**
* CompletenessTest
*/
- // Adds toggle checkbox to header
+ // Adds toggle checkbox to header
QUnit.config.urlConfig.push( {
id: 'completenesstest',
label: 'Run CompletenessTest',
diff --git a/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
b/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
index deff5b0..6159bdb 100644
--- a/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
+++ b/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
@@ -614,7 +614,7 @@
}
);
- QUnit.test( 'Test detection routine', function ( assert ) {
+ QUnit.test( 'Test detection routine', 1, function ( assert ) {
var $table;
$table = $(
'<table class="sortable">' +
@@ -635,7 +635,7 @@
} );
/** FIXME: the diff output is not very readeable. */
- QUnit.test( 'bug 32047 - caption must be before thead', function (
assert ) {
+ QUnit.test( 'bug 32047 - caption must be before thead', 1, function (
assert ) {
var $table;
$table = $(
'<table class="sortable">' +
@@ -655,7 +655,7 @@
);
} );
- QUnit.test( 'data-sort-value attribute, when available, should override
sorting position', function ( assert ) {
+ QUnit.test( 'data-sort-value attribute, when available, should override
sorting position', 3, function ( assert ) {
var $table, data;
// Example 1: All cells except one cell without data-sort-value,
@@ -925,7 +925,7 @@
}
);
- QUnit.test( 'Sorting images using alt text', function ( assert ) {
+ QUnit.test( 'Sorting images using alt text', 1, function ( assert ) {
var $table = $(
'<table class="sortable">' +
'<tr><th>THEAD</th></tr>' +
@@ -942,7 +942,7 @@
);
} );
- QUnit.test( 'Sorting images using alt text (complex)', function (
assert ) {
+ QUnit.test( 'Sorting images using alt text (complex)', 1, function (
assert ) {
var $table = $(
'<table class="sortable">' +
'<tr><th>THEAD</th></tr>' +
@@ -963,7 +963,7 @@
);
} );
- QUnit.test( 'Sorting images using alt text (with format
autodetection)', function ( assert ) {
+ QUnit.test( 'Sorting images using alt text (with format
autodetection)', 1, function ( assert ) {
var $table = $(
'<table class="sortable">' +
'<tr><th>THEAD</th></tr>' +
diff --git
a/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
b/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
index 9389651..ee854ae 100644
---
a/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
+++
b/tests/qunit/suites/resources/mediawiki.special/mediawiki.special.recentchanges.test.js
@@ -3,7 +3,7 @@
// TODO: verify checkboxes == [ 'nsassociated', 'nsinvert' ]
- QUnit.test( '"all" namespace disable checkboxes', function ( assert ) {
+ QUnit.test( '"all" namespace disable checkboxes', 8, function ( assert
) {
var selectHtml, $env, $options;
// from Special:Recentchanges
--
To view, visit https://gerrit.wikimedia.org/r/53188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I214b3d4da46f3f3bb0fcde313ac2d82439e40e3c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
