Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/385407 )
Change subject: Report filesize, and don't delete misc props from intermediate
response
......................................................................
Report filesize, and don't delete misc props from intermediate response
A client might actually want to know a media file size, so let's pass it
through to the result.
The other properties' being in the intermediate response doesn't matter.
Bug: T177430
Change-Id: Ie62f9395828b8217241e452b4b211d82e35fffff
---
M lib/gallery.js
1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/07/385407/1
diff --git a/lib/gallery.js b/lib/gallery.js
index efc69a6..a8315db 100644
--- a/lib/gallery.js
+++ b/lib/gallery.js
@@ -31,6 +31,7 @@
mime: obj.mime,
width: obj.width,
height: obj.height,
+ size: obj.size,
derivatives: obj.derivatives,
ext: getExtMetadataValues(obj.extmetadata)
};
@@ -85,12 +86,6 @@
});
items.forEach((item) => {
- delete item.ns;
- delete item.imagerepository; // we probably don't care where the repo
is
- delete item.imageinfo[0].size;
- // TODO: instead of deleting properties we probably want to just add
well-known
- // properties
-
const mime = item.imageinfo[0].mime;
isVideo = mime.indexOf('ogg') > -1 || mime.indexOf('video') > -1;
--
To view, visit https://gerrit.wikimedia.org/r/385407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie62f9395828b8217241e452b4b211d82e35fffff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
