Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/55650


Change subject: Properly set Revision::mTextId in PostgreSQL on insert.
......................................................................

Properly set Revision::mTextId in PostgreSQL on insert.

Change-Id: I1df0fe56e5deeb1c5c2b632d54a09f1f1a781b32
---
M includes/Revision.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/50/55650/1

diff --git a/includes/Revision.php b/includes/Revision.php
index 2b34984..9d0675d 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -1296,7 +1296,7 @@
                                        'old_flags' => $flags,
                                ), __METHOD__
                        );
-                       $this->mTextId = $dbw->insertId();
+                       $this->mTextId = $old_id ?: $dbw->insertId();
                }
 
                if ( $this->mComment === null ) $this->mComment = "";
@@ -1346,7 +1346,7 @@
 
                $dbw->insert( 'revision', $row, __METHOD__ );
 
-               $this->mId = !is_null( $rev_id ) ? $rev_id : $dbw->insertId();
+               $this->mId = $rev_id ?: $dbw->insertId();
 
                wfRunHooks( 'RevisionInsertComplete', array( &$this, $data, 
$flags ) );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/55650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1df0fe56e5deeb1c5c2b632d54a09f1f1a781b32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to