Christian has uploaded a new change for review.
https://gerrit.wikimedia.org/r/55791
Change subject: Committing failing test for feedback
......................................................................
Committing failing test for feedback
This test inserts two complete paragraphs into a paragraph. I would expect that
the inserted-into paragraph would terminate, the new paragraphs would be
inserted, and a new opening paragraph would be created for the remainder of the
inserted-into paragraph. This almost happens, but an additional empty paragraph
is added between the two that I'm inserting.
Change-Id: I35e54165709ac56e8116359a7c3b487eecf08ff7
---
M modules/ve/test/dm/ve.dm.Transaction.test.js
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/91/55791/1
diff --git a/modules/ve/test/dm/ve.dm.Transaction.test.js
b/modules/ve/test/dm/ve.dm.Transaction.test.js
index 16021ac..1d1347a 100644
--- a/modules/ve/test/dm/ve.dm.Transaction.test.js
+++ b/modules/ve/test/dm/ve.dm.Transaction.test.js
@@ -176,6 +176,18 @@
{ 'type': 'retain', 'length': 27 }
]
},
+ 'insert two complete paragraphs into a paragraph': {
+ 'args': [doc, 10, [{ 'type': 'paragraph' }, 'F', 'O',
'O', { 'type': '/paragraph' }, { 'type': 'paragraph' }, 'B', 'A', 'R', {
'type': '/paragraph' }]],
+ 'ops': [
+ { 'type': 'retain', 'length': 10 },
+ {
+ 'type': 'replace',
+ 'remove': [],
+ 'insert': [{ 'type': '/paragraph' }, {
'type': 'paragraph' }, 'F', 'O', 'O', { 'type': '/paragraph' }, { 'type':
'paragraph' }, 'B', 'A', 'R', { 'type': '/paragraph' }, { 'type': 'paragraph' }]
+ },
+ { 'type': 'retain', 'length': 51 }
+ ]
+ },
'inserting two paragraphs into a document with just an empty
paragraph': {
'args': [doc2, 1, ['F', 'O', 'O', { 'type':
'/paragraph' }, { 'type': 'paragraph' }, 'B', 'A', 'R']],
'ops': [
--
To view, visit https://gerrit.wikimedia.org/r/55791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35e54165709ac56e8116359a7c3b487eecf08ff7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Christian <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
