Phedenskog has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386074 )
Change subject: Do not filter out zero values.
......................................................................
Do not filter out zero values.
Bug: T178479
Change-Id: I0d178cf43c78c0c4db8ae137ce14c35fccddc1be
---
M modules/ext.navigationTiming.js
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NavigationTiming
refs/changes/74/386074/1
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index bca2a77..e5ffe15 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -120,13 +120,13 @@
'responseStart',
'secureConnectionStart'
], function ( i, marker ) {
- // Verify the key exists and that it is above zero to
avoid submit
- // of invalid or negative values after subtracting
navStart.
+ // Verify the key exists and that it is equal or above
zero to avoid submit
+ // of invalid/negative values after subtracting
navStart.
// While these keys are meant to be timestamps, they
may be absent
// or 0 where the measured operation did not ocurr.
// E.g. secureConnectionStart is 0 when the connection
is reused (T176105)
var value = timing[ marker ];
- if ( typeof value === 'number' && value > 0 ) {
+ if ( typeof value === 'number' && value >= 0 ) {
timingData[ marker ] = value - navStart;
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/386074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d178cf43c78c0c4db8ae137ce14c35fccddc1be
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: master
Gerrit-Owner: Phedenskog <phedens...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
