jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/386012 )
Change subject: Document why ApiBase is overridden and add isInternal member ...................................................................... Document why ApiBase is overridden and add isInternal member Bug: T91456 Change-Id: I41c20e81238f40448e5ad6328c3a61673a3d5207 --- M includes/ApiZeroBanner.php 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Yurik: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/ApiZeroBanner.php b/includes/ApiZeroBanner.php index 5c565e6..6e30bf0 100644 --- a/includes/ApiZeroBanner.php +++ b/includes/ApiZeroBanner.php @@ -7,7 +7,9 @@ use ApiResult; /** - * Utility class to avoid any warnings or any other additions by the API framework + * Utility class to avoid any warnings or any other additions by the + * API framework. This class extends ApiBase in order to shrink + * responses for clients. * Class ApiRawJsonPrinter * @package ZeroBanner */ @@ -41,6 +43,9 @@ /** * Override built-in handling of format parameter. * Only JSON is supported. + * This class extends ApiBase in order to generate Wikipedia Zero + * specific output, as used for example by native apps and + * JavaScript-capable clients. * @return ApiFormatBase */ public function getCustomPrinter() { @@ -207,4 +212,11 @@ => 'apihelp-zeroconfig-example-2', ]; } + + /** + * @inheritDoc + */ + public function isInternal() { + return true; + } } -- To view, visit https://gerrit.wikimedia.org/r/386012 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41c20e81238f40448e5ad6328c3a61673a3d5207 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ZeroBanner Gerrit-Branch: master Gerrit-Owner: Dr0ptp4kt <ab...@wikimedia.org> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: BBlack <bbl...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Joewalsh <joewa...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Yurik <yuriastrak...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits