Subramanya Sastry has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386098 )
Change subject: Add tidy-font-bug linter high-priority category
......................................................................
Add tidy-font-bug linter high-priority category
* <font> tags with color attribute that wrap links and images
will have different behavior and hence rendering compared to Tidy.
Change-Id: I7a551ef9b7e8f57d7a43c823832f0e3add6b1367
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M includes/CategoryManager.php
M includes/LintErrorsPager.php
5 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Linter
refs/changes/98/386098/1
diff --git a/extension.json b/extension.json
index 6ce3aa3..566ef08 100644
--- a/extension.json
+++ b/extension.json
@@ -116,6 +116,11 @@
"enabled": true,
"priority": "high",
"parser-migration": true
+ },
+ "tidy-font-bug": {
+ "enabled": true,
+ "priority": "high",
+ "parser-migration": true
}
},
"LinterSubmitterWhitelist": {
diff --git a/i18n/en.json b/i18n/en.json
index 11b097c..451893c 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -45,6 +45,8 @@
"linter-category-tidy-whitespace-bug-desc": "These pages trigger a tidy
whitespace bug that should be worked around.",
"linter-category-html5-misnesting": "Misnested tag with different
rendering in HTML5 and HTML4",
"linter-category-html5-misnesting-desc": "These misnested tags will
behave differently in HTML5 compared to HTML4.",
+ "linter-category-tidy-font-bug": "Tidy bug affecting font tags wrapping
links",
+ "linter-category-tidy-font-bug-desc": "Tidy moves these font tags
inside links to change link colour",
"linter-numerrors": "($1 {{PLURAL:$1|error|errors}})",
"linker-page-title-edit": "$1 ($2)",
"linker-page-edit": "edit",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 7d9f15c..aac9405 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -25,6 +25,7 @@
"linter-pager-pwrap-bug-workaround-details": "Table column heading",
"linter-pager-tidy-whitespace-bug-details": "Table column heading.
\"Tidy\" is a name of a software package that transforms HTML files, so it
doesn't have to be translated. For information about the bug, see the commit
message https://gerrit.wikimedia.org/r/#/c/371068 .",
"linter-pager-html5-misnesting-details": "Table column heading.",
+ "linter-pager-tidy-font-bug-details": "Table column heading.",
"linter-category-fostered": "Name of lint error category. See
[[:mw:Help:Extension:Linter/fostered]]",
"linter-category-fostered-desc": "Description of category.",
"linter-category-obsolete-tag": "Name of lint error category. See
[[:mw:Help:Extension:Linter/obsolete-tag]]",
@@ -49,6 +50,8 @@
"linter-category-tidy-whitespace-bug-desc": "Description of category.",
"linter-category-html5-misnesting": "Name of lint error category. See
[[:mw:Help:Extension:Linter/html5-misnesting]]",
"linter-category-html5-misnesting-desc": "Description of category",
+ "linter-category-tidy-font-bug": "Name of lint error category. See
[[:mw:Help:Extension:Linter/tidy-font-bug]]",
+ "linter-category-tidy-font-bug-desc": "Description of category",
"linter-numerrors": "Shown after a category link to indicate how many
errors are in that category. $1 is the number of errors, and can be used for
PLURAL.\n{{Identical|Error}}",
"linker-page-title-edit": "Used in a table cell. $1 is a link to the
page, $2 is pipe separated links to the edit and history pages, the link text
is {{msg-mw|linker-page-edit}} and {{msg-mw|linker-page-history}}",
"linker-page-edit": "Link text for edit link in
{{msg-mw|linker-page-title-edit}}\n{{Identical|Edit}}",
diff --git a/includes/CategoryManager.php b/includes/CategoryManager.php
index 614bf17..3e57251 100644
--- a/includes/CategoryManager.php
+++ b/includes/CategoryManager.php
@@ -48,6 +48,7 @@
'tidy-whitespace-bug' => 10,
'multi-colon-escape' => 11,
'html5-misnesting' => 12,
+ 'tidy-font-bug' => 13,
];
/**
diff --git a/includes/LintErrorsPager.php b/includes/LintErrorsPager.php
index 43b6473..f7ee521 100644
--- a/includes/LintErrorsPager.php
+++ b/includes/LintErrorsPager.php
@@ -143,6 +143,7 @@
'misnested-tag',
'stripped-tag',
'html5-misnesting',
+ 'tidy-font-bug',
];
if ( in_array( $this->category, $hasNameCats )
&& isset( $lintError->params['name'] ) ) {
return Html::element( 'code', [],
$lintError->params['name'] );
--
To view, visit https://gerrit.wikimedia.org/r/386098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a551ef9b7e8f57d7a43c823832f0e3add6b1367
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Linter
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
