Volans has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386110 )
Change subject: Use the hiera() value in the message
......................................................................
Use the hiera() value in the message
* When reporting invalid hiera calls, add the value of the hiera call to
the message to make messages unique, so that they can be easily
distinguished when comparing previous and current linter violations.
Change-Id: Ia59fe90a11ed55576d7564a9c6a9dd417a7e1372
---
M lib/puppet-lint/plugins/check_wmf_styleguide.rb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/operations/puppet-lint/wmf_styleguide-check
refs/changes/10/386110/1
diff --git a/lib/puppet-lint/plugins/check_wmf_styleguide.rb
b/lib/puppet-lint/plugins/check_wmf_styleguide.rb
index 1bd9e58..d28cbfa 100644
--- a/lib/puppet-lint/plugins/check_wmf_styleguide.rb
+++ b/lib/puppet-lint/plugins/check_wmf_styleguide.rb
@@ -218,7 +218,7 @@
def hiera_errors(tokens, klass)
tokens.each do |token|
msg = {
- message: "wmf-style: Found hiera call in #{klass.type} '#{klass.name}'",
+ message: "wmf-style: Found hiera call in #{klass.type} '#{klass.name}'
for '#{token.next_token.next_token.value}'",
line: token.line,
column: token.column
}
--
To view, visit https://gerrit.wikimedia.org/r/386110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia59fe90a11ed55576d7564a9c6a9dd417a7e1372
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet-lint/wmf_styleguide-check
Gerrit-Branch: master
Gerrit-Owner: Volans <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
