jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/385021 )
Change subject: Replace deprecated jQuery.isArray by Array.isArray ...................................................................... Replace deprecated jQuery.isArray by Array.isArray jQuery.isArray is deprecated since jQuery 3.2.0. [1] Array.isArray is part of ES5 and is supported since the following browser versions: [2] * Chrome 5 * Firefox (Gecko) 4.0 (2.0) * Internet Explorer 9 * Opera 10.5 * Safari 5 This change requires MediaWiki 1.29+ which ensures that JavaScript is only used when the browser supports ES5. [1] https://blog.jquery.com/2017/03/16/jquery-3-2-0-is-out/ [2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray#Browser_compatibility Change-Id: I275c470a06109727e4a76b13f0426e5c0b4d8e6f --- M resources/ext.wikiLove.core.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/ext.wikiLove.core.js b/resources/ext.wikiLove.core.js index c791a83..338fa9a 100644 --- a/resources/ext.wikiLove.core.js +++ b/resources/ext.wikiLove.core.js @@ -387,7 +387,7 @@ $( '#mw-wikilove-image' ).val( currentRememberData.image || currentTypeOrSubtype.image || '' ); if( typeof currentTypeOrSubtype.gallery === 'object' && - $.isArray( currentTypeOrSubtype.gallery.imageList ) + Array.isArray( currentTypeOrSubtype.gallery.imageList ) ) { $( '#mw-wikilove-gallery, #mw-wikilove-gallery-label' ).show(); $.wikiLove.showGallery(); // build gallery from array of images -- To view, visit https://gerrit.wikimedia.org/r/385021 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I275c470a06109727e4a76b13f0426e5c0b4d8e6f Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/WikiLove Gerrit-Branch: master Gerrit-Owner: Fomafix <foma...@googlemail.com> Gerrit-Reviewer: Fomafix <foma...@googlemail.com> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
