jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386030 )
Change subject: Remove unnecessary API call in unit test
......................................................................
Remove unnecessary API call in unit test
We do not need to hit the API in this test. It's unnecessary and makes
the test harder to comprehend.
Instead of testing this way, simulate a promise that resolves without
pages.
(npm run test:unit should work without an internet connection)
Change-Id: Iee834114890a64c96ccf255601503a25efd884bc
---
M test/lib/api-util/api-util-test.js
1 file changed, 3 insertions(+), 19 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
Mholloway: Looks good to me, but someone else must approve
diff --git a/test/lib/api-util/api-util-test.js
b/test/lib/api-util/api-util-test.js
index 33ef32b..4080c58 100644
--- a/test/lib/api-util/api-util-test.js
+++ b/test/lib/api-util/api-util-test.js
@@ -1,6 +1,5 @@
'use strict';
-const preq = require('preq');
const assert = require('../../utils/assert');
const mwapi = require('../../../lib/mwapi');
@@ -11,26 +10,11 @@
logger.log = function(a, b) {};
-describe('lib:apiUtil', function() {
-
- this.timeout(20000); // eslint-disable-line no-invalid-this
+describe('lib:apiUtil', () => {
it('checkForQueryPagesInResponse should return 504 when query.pages are
absent', () => {
- return preq.post({
- uri: 'https://commons.wikimedia.org/w/api.php',
- body: {
- action: 'query',
- format: 'json',
- formatversion: 2,
- generator: 'images',
- prop: 'imageinfo|revisions',
- iiextmetadatafilter: 'ImageDescription',
- iiextmetadatamultilang: true,
- iiprop: 'url|extmetadata|dimensions',
- iiurlwidth: 1024,
- rawcontinue: '',
- titles: `Template:Potd/1980-07-06`
- }
+ return new Promise((resolve) => {
+ return resolve({});
}).then((response) => {
assert.throws(() => {
mwapi.checkForQueryPagesInResponse({ logger }, response);
--
To view, visit https://gerrit.wikimedia.org/r/386030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee834114890a64c96ccf255601503a25efd884bc
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org>
Gerrit-Reviewer: GWicke <gwi...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
