Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386123 )
Change subject: Don't use subprocess.run(), it's Python 3.5+
......................................................................
Don't use subprocess.run(), it's Python 3.5+
And jessie has 3.4.
Change-Id: I3c38c3e63a6fe2ddf0930b75a19f4c74b6232cc2
---
M docker.py
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/libraryupgrader
refs/changes/23/386123/1
diff --git a/docker.py b/docker.py
index 5c2166a..4abef7e 100644
--- a/docker.py
+++ b/docker.py
@@ -51,12 +51,11 @@
def logs(name: str) -> str:
- out = subprocess.run(
+ out = subprocess.check_output(
['docker', 'logs', name],
- stdout=subprocess.PIPE,
stderr=subprocess.STDOUT
)
- return out.stdout.decode()
+ return out.decode()
def remove_container(name: str):
--
To view, visit https://gerrit.wikimedia.org/r/386123
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c38c3e63a6fe2ddf0930b75a19f4c74b6232cc2
Gerrit-PatchSet: 1
Gerrit-Project: labs/libraryupgrader
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
