jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386117 )
Change subject: WikimediaUI theme: Visually improve MenuSectionOptionWidget
MenuOptions
......................................................................
WikimediaUI theme: Visually improve MenuSectionOptionWidget MenuOptions
Improve MenuSectionOptionWidget and its sectioned MenuOptionWidgets
visual treatment by identing them.
Also updated MenuSectionOptionWidget containing widgets in demo slightly.
Bug: T92452
Change-Id: I7558b0eaaefcea36cbb85ce3626e6fa27e8d73b8
---
M demos/pages/widgets.js
M src/themes/wikimediaui/widgets.less
2 files changed, 15 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/demos/pages/widgets.js b/demos/pages/widgets.js
index 31678e3..713f536 100644
--- a/demos/pages/widgets.js
+++ b/demos/pages/widgets.js
@@ -1259,7 +1259,8 @@
} ),
new
OO.ui.MenuOptionWidget( {
data:
'poodle',
- label:
'Standard Poodle'
+ label:
'Standard Poodle',
+ icon:
'star'
} ),
new
OO.ui.MenuSectionOptionWidget( {
label:
'Cats'
@@ -1928,7 +1929,7 @@
}
} ),
{
- label:
'CapsuleMultiselectWidget (with sections)',
+ label:
'CapsuleMultiselectWidget (sectioned by MenuSectionOptionWidget)',
align: 'top'
}
),
diff --git a/src/themes/wikimediaui/widgets.less
b/src/themes/wikimediaui/widgets.less
index 5023370..d4e3785 100644
--- a/src/themes/wikimediaui/widgets.less
+++ b/src/themes/wikimediaui/widgets.less
@@ -784,6 +784,18 @@
color: @color-base--subtle;
padding: @padding-top-menu @padding-horizontal-base
@padding-vertical-label;
font-weight: bold;
+
+ & ~ .oo-ui-menuOptionWidget {
+ padding-left: 2 * @padding-horizontal-base;
+
+ &.oo-ui-iconElement {
+ padding-left: @padding-start-menu-icon-label +
@padding-horizontal-base;
+
+ .oo-ui-iconElement-icon {
+ left: 2 * @padding-horizontal-base;
+ }
+ }
+ }
}
.theme-oo-ui-menuSelectWidget () {
--
To view, visit https://gerrit.wikimedia.org/r/386117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7558b0eaaefcea36cbb85ce3626e6fa27e8d73b8
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
