Mepps has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386256 )
Change subject: Revert "Handle payment not initiated"
......................................................................
Revert "Handle payment not initiated"
This reverts commit 2eff18302b1736bef07428ea8e15fac84c7a43ab.
Change-Id: I70a45cbdfc5d3883aeb8502080d9778f646b5650
---
M paypal_gateway/express_checkout/paypal_express.adapter.php
1 file changed, 7 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/56/386256/1
diff --git a/paypal_gateway/express_checkout/paypal_express.adapter.php
b/paypal_gateway/express_checkout/paypal_express.adapter.php
index 2a605bb..cd1afed 100644
--- a/paypal_gateway/express_checkout/paypal_express.adapter.php
+++ b/paypal_gateway/express_checkout/paypal_express.adapter.php
@@ -555,6 +555,13 @@
throw new ResponseProcessingException(
'Failed to create a recurring profile',
ResponseCodes::UNKNOWN );
}
+ } else {
+ // One-time payment, or initial payment in a
subscription.
+ $resultData = $this->do_transaction(
'DoExpressCheckoutPayment' );
+ if ( !$resultData->getCommunicationStatus() ) {
+ $this->finalizeInternalStatus(
FinalStatus::FAILED );
+ return PaymentResult::newFailure();
+ }
}
return PaymentResult::fromResults(
$this->getTransactionResponse(),
--
To view, visit https://gerrit.wikimedia.org/r/386256
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70a45cbdfc5d3883aeb8502080d9778f646b5650
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: deployment
Gerrit-Owner: Mepps <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
