jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386171 )
Change subject: Scroll to the next highlight after find and replace has
replaced text
......................................................................
Scroll to the next highlight after find and replace has replaced text
Right now when you're doing find and replace, each time you replace, the
next occurrence of the term is highlighted, but not scrolled to. This is
unexpected, and can lead to you being quite far away from the highlighted
text if you keep replacing things. This patch fixes that by scrolling to
the highlighted text each time something is replaced.
Bug: T177514
Change-Id: Ic5a39f681260c910668bb1ea3a27aa2c62f14383
---
M src/ui/dialogs/ve.ui.FindAndReplaceDialog.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, but someone else must approve
diff --git a/src/ui/dialogs/ve.ui.FindAndReplaceDialog.js
b/src/ui/dialogs/ve.ui.FindAndReplaceDialog.js
index 0b547d9..ac3e622 100644
--- a/src/ui/dialogs/ve.ui.FindAndReplaceDialog.js
+++ b/src/ui/dialogs/ve.ui.FindAndReplaceDialog.js
@@ -598,6 +598,9 @@
this.clearRenderedResultsCache();
this.renderFragments();
+
+ // Wherever we end up, scroll to whatever we've got focused
+ this.highlightFocused( true );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/386171
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5a39f681260c910668bb1ea3a27aa2c62f14383
Gerrit-PatchSet: 4
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Deskana <dga...@wikimedia.org>
Gerrit-Reviewer: Deskana <dga...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
