Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386420 )
Change subject: SpecialPage: Hard deprecate getTitle, deprecated since 1.23
......................................................................
SpecialPage: Hard deprecate getTitle, deprecated since 1.23
Change-Id: I839e9aaa0be7491087cc144ea13153abb2e77aa6
---
M includes/specialpage/SpecialPage.php
M includes/specials/forms/PreferencesForm.php
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/20/386420/1
diff --git a/includes/specialpage/SpecialPage.php
b/includes/specialpage/SpecialPage.php
index 4c3ca54..12206dc 100644
--- a/includes/specialpage/SpecialPage.php
+++ b/includes/specialpage/SpecialPage.php
@@ -615,6 +615,7 @@
* @deprecated since 1.23, use SpecialPage::getPageTitle
*/
function getTitle( $subpage = false ) {
+ wfDeprecated( __METHOD__, '1.23' );
return $this->getPageTitle( $subpage );
}
diff --git a/includes/specials/forms/PreferencesForm.php
b/includes/specials/forms/PreferencesForm.php
index d4e5ef4..f6a81ff 100644
--- a/includes/specials/forms/PreferencesForm.php
+++ b/includes/specials/forms/PreferencesForm.php
@@ -80,7 +80,7 @@
$html = parent::getButtons();
if ( $this->getModifiedUser()->isAllowed( 'editmyoptions' ) ) {
- $t = $this->getTitle()->getSubpage( 'reset' );
+ $t = $this->getPageTitle()->getSubpage( 'reset' );
$linkRenderer =
MediaWikiServices::getInstance()->getLinkRenderer();
$html .= "\n" . $linkRenderer->makeLink( $t,
$this->msg( 'restoreprefs' )->text(),
--
To view, visit https://gerrit.wikimedia.org/r/386420
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I839e9aaa0be7491087cc144ea13153abb2e77aa6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
