jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386911 )
Change subject: Limit logged skins for print event only to vector and minerva
......................................................................
Limit logged skins for print event only to vector and minerva
We want to keep print events for longer than 90 days so we can do
more complex analysis in the future. While we defined the purge
strategy we found out that skin information potentially might
identify users who're printing.
Because of that we decided to store only vector and minerva skin
information as those are not identifying users, we will use it as
a lose identification of mobile vs non-mobile users. For all other
skins we will store 'other'. It will help us identify the percentage
ratio between most popular skins (minerva & vector) and all other
skins.
Bug: T169730
Bug: T175395
Change-Id: If527d2085211e9d23562965943712fda5248d72a
---
M modules/ext.wikimediaEvents.print.js
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/modules/ext.wikimediaEvents.print.js
b/modules/ext.wikimediaEvents.print.js
index 18e37e9..6e400d0 100644
--- a/modules/ext.wikimediaEvents.print.js
+++ b/modules/ext.wikimediaEvents.print.js
@@ -17,12 +17,17 @@
* schema Schema:Print
*/
function logEvent( action ) {
+ var skin = config.get( 'skin' );
+ if ( skin !== 'vector' && skin !== 'minerva' ) {
+ skin = 'other';
+ }
+
track( 'event.Print', {
sessionToken: user.sessionId(),
isAnon: user.isAnon(),
pageTitle: config.get( 'wgPageName' ),
namespaceId: config.get( 'wgNamespaceNumber' ),
- skin: config.get( 'skin' ),
+ skin: skin,
action: action
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/386911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If527d2085211e9d23562965943712fda5248d72a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
