Tobias Gritschacher has submitted this change and it was merged.
Change subject: Deal with all our tests failing since I214b3d4 got merged into
core
......................................................................
Deal with all our tests failing since I214b3d4 got merged into core
For now this seems like the fastest fix. Until it is clear what I214b3d4 is
actuallz required for
and we might adjust or find an alternative way, this global hack will do its
service without caring
too much about other extensions.
Change-Id: I43ac49687c72284acc0907d9367b77d84816ca64
---
M DataValues/tests/qunit/DataValues.tests.js
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Tobias Gritschacher: Verified; Looks good to me, approved
diff --git a/DataValues/tests/qunit/DataValues.tests.js
b/DataValues/tests/qunit/DataValues.tests.js
index d177739..819b1f2 100644
--- a/DataValues/tests/qunit/DataValues.tests.js
+++ b/DataValues/tests/qunit/DataValues.tests.js
@@ -4,9 +4,14 @@
* @licence GNU GPL v2+
* @author Jeroen De Dauw < jeroended...@gmail.com >
*/
-( function( dv, $, QUnit, undefined ) {
+( function( dv, $, QUnit ) {
'use strict';
+ // Fix for msot of our tests no having the number of required
assertions.
+ // This is required since I214b3d4 got merged into core.
+ // TODO: figure out some non-global alternative to deal with this.
+ QUnit.config.requireExpects = false;
+
QUnit.module( 'DataValues.js', QUnit.newMwEnvironment() );
QUnit.test(
--
To view, visit https://gerrit.wikimedia.org/r/55886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43ac49687c72284acc0907d9367b77d84816ca64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
