Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/387589 )

Change subject: Update: use CSS border-box box model
......................................................................

Update: use CSS border-box box model

We don't yet know what all the implications of this change will be
across wikis but we want to start seeing any issues that exist sooner
rather than later. This patch adds the border-box box model for all
elements but may later be reverted or selectively disabled for wiki
content if found to be problematic.

Bug: T176999
Change-Id: I443658458da2eaa3e945de886becf6bbd71d3e03
---
M src/client/index.css
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/89/387589/1

diff --git a/src/client/index.css b/src/client/index.css
index 57f7179..197750c 100644
--- a/src/client/index.css
+++ b/src/client/index.css
@@ -42,6 +42,14 @@
 /* Remove extra margin, expand base elements to the viewport height */
 html, body, #root { margin: 0; height: 100%; }
 
+/* Use the border box model so that element width and height _include_ any
+   border and padding in their specification. This allows Marvin to intutively
+   write things like `body { width: 100%; padding: 1em; }` without exceeding 
the
+   screen size, for example.
+   
https://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/
 */
+html { box-sizing: border-box; }
+*, *:before, *:after { box-sizing: inherit; }
+
 /* Base layer */
 body {
   background-color: var(--wmui-color-base80);

-- 
To view, visit https://gerrit.wikimedia.org/r/387589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I443658458da2eaa3e945de886becf6bbd71d3e03
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to