jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386470 )
Change subject: resources: Remove deprecated 'jquery.placeholder' module
......................................................................
resources: Remove deprecated 'jquery.placeholder' module
Change-Id: I1f14561e54df477067460411ff155e3f2eeb167a
---
M RELEASE-NOTES-1.31
M resources/Resources.php
D resources/src/jquery/jquery.placeholder.js
M resources/src/mediawiki.less/mediawiki.mixins.less
4 files changed, 1 insertion(+), 28 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 17dba87..5e2df5f 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -33,6 +33,7 @@
* (T17845) The deprecated 'jquery.badge' module was removed.
* The deprecated 'jquery.autoEllipsis' module was removed. Use the CSS
text-overflow property instead.
+* The deprecated 'jquery.placeholder' module was removed.
* …
=== Bug fixes in 1.31 ===
diff --git a/resources/Resources.php b/resources/Resources.php
index 545a84c..9acc0ef 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -286,12 +286,6 @@
'scripts' => 'resources/src/jquery/jquery.mw-jump.js',
'targets' => [ 'desktop', 'mobile' ],
],
- 'jquery.placeholder' => [
- 'deprecated' => 'Use of "jquery.placeholder" is deprecated
since MediaWiki 1.29.0',
-
- 'scripts' => 'resources/src/jquery/jquery.placeholder.js',
- 'targets' => [ 'desktop', 'mobile' ],
- ],
'jquery.qunit' => [
'scripts' => 'resources/lib/qunitjs/qunit.js',
'styles' => 'resources/lib/qunitjs/qunit.css',
diff --git a/resources/src/jquery/jquery.placeholder.js
b/resources/src/jquery/jquery.placeholder.js
deleted file mode 100644
index afb8837..0000000
--- a/resources/src/jquery/jquery.placeholder.js
+++ /dev/null
@@ -1,18 +0,0 @@
-/*!
- * No-op for compatibility with code from before we used
- * native placeholder in all supported browsers.
- */
-
-( function ( $ ) {
- var placeholder;
-
- placeholder = $.fn.placeholder = function ( text ) {
- if ( arguments.length ) {
- this.prop( 'placeholder', text );
- }
- return this;
- };
-
- placeholder.input = placeholder.textarea = true;
-
-}( jQuery ) );
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less
b/resources/src/mediawiki.less/mediawiki.mixins.less
index fb3b00e..ea0b959 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.less
@@ -171,10 +171,6 @@
&::placeholder {
@rules();
}
- // For inputs that use jquery.placeholder.js e.g. IE9
- &.placeholder {
- @rules();
- }
}
/* stylelint-enable selector-no-vendor-prefix, at-rule-no-unknown */
--
To view, visit https://gerrit.wikimedia.org/r/386470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f14561e54df477067460411ff155e3f2eeb167a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
